Skip to content

Remove call to chain observer on pending certificate route #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2024
Merged

Remove call to chain observer on pending certificate route #1808

merged 6 commits into from
Jul 9, 2024

Conversation

@sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Jul 9, 2024 •
edited by dlachaume
Loading

Content

Improve certificate pending route performance of the aggregator removing the call to the Chain Observer used to retrieve the time point.
The beacon is now optional in the certificate pending route so it could be removed in a future version.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Result of ab command on testing-preview with 1000 requests before applying changes:
ab -n 1000 -c 10 -w https://aggregator.testing-preview.api.mithril.network/aggregator/certificate-pending

key value
Server Hostname aggregator.testing-preview.api.mithril.network
Server Port 443
Document Path /aggregator/certificate-pending
Concurrency Level 10
run Requests per second
1 27.58
2 27.89
3 28.33
4 27.93
5 28.02

Result of the same ab command on testing-preview with 1000 requests after applying changes:

run Requests per second
1 100.12
2 98.16
3 92.11
4 96.62
5 96.37

Issue(s)

Closes #1804

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 9, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   8m 58s ⏱️ +14s
1 145 tests +4  1 145 ✅ +4  0 💤 ±0  0 ❌ ±0 
1 311 runs  +4  1 311 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit e9dbe66. ± Comparison against base commit 380a4bf.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel force-pushed the ensemble/1804/remove_call_to_chain_observer_on_pending_certificate_route branch from 2e2dcc9 to de1328f Compare July 9, 2024 09:06
@sfauvel sfauvel force-pushed the ensemble/1804/remove_call_to_chain_observer_on_pending_certificate_route branch from de1328f to 93fa124 Compare July 9, 2024 09:07
@sfauvel sfauvel changed the title Ensemble/1804/remove call to chain observer on pending certificate route Remove call to chain observer on pending certificate route Jul 9, 2024
@sfauvel sfauvel temporarily deployed to testing-preview July 9, 2024 09:14 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 9, 2024 09:14 — with GitHub Actions Inactive
@dlachaume dlachaume marked this pull request as ready for review July 9, 2024 09:47
@dlachaume dlachaume requested a review from jpraynaud July 9, 2024 09:47
jpraynaud
jpraynaud reviewed Jul 9, 2024
View reviewed changes
@sfauvel sfauvel force-pushed the ensemble/1804/remove_call_to_chain_observer_on_pending_certificate_route branch from 93fa124 to 0d8d948 Compare July 9, 2024 09:58
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 9, 2024
View reviewed changes
jpraynaud
jpraynaud approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel force-pushed the ensemble/1804/remove_call_to_chain_observer_on_pending_certificate_route branch from 0d8d948 to e9dbe66 Compare July 9, 2024 13:06
@sfauvel sfauvel temporarily deployed to testing-preview July 9, 2024 13:14 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet July 9, 2024 13:14 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 640ee4d into main Jul 9, 2024
@sfauvel sfauvel deleted the ensemble/1804/remove_call_to_chain_observer_on_pending_certificate_route branch July 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

+1 more reviewer

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Certificate pending route overwhelms the Cardano node in aggregator

4 participants

@sfauvel @jpraynaud @dlachaume